Skip to content

Add tom-dudman/DS1804 #5606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 15, 2024
Merged

Add tom-dudman/DS1804 #5606

merged 2 commits into from
Dec 15, 2024

Conversation

@tom-dudman
Copy link
Contributor

@tom-dudman tom-dudman commented Dec 15, 2024

No description provided.

@github-actions github-actions bot added the topic: submission Add library to the list label Dec 15, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2024

❌ ERROR: Arduino Lint found errors with https://github.com/tom-dudman/DS1804:

Linting library in DS1804
ERROR: Library name DS1804 is in use by a library in the Library Manager index. Each library must have a unique name    
       value. If your library is already in the index, use the "--library-manager update" flag.                         
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format           
       (Rule LP017)                                                                                                     

Linter results for project: 1 ERRORS, 0 WARNINGS

-------------------

Linting sketch in DS1804/examples/non_volatile

Linter results for project: no errors or warnings

-------------------

Linting sketch in DS1804/examples/rate_limited

Linter results for project: no errors or warnings

-------------------

Linting sketch in DS1804/examples/serial_control

Linter results for project: no errors or warnings

-------------------

Linting sketch in DS1804/examples/validity_checker

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 0 WARNINGS

@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2024

Thanks for your interest in contributing to the Arduino Library Manager index @tom-dudman
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

❗ NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@tom-dudman
Copy link
Contributor Author

tom-dudman commented Dec 15, 2024

@ArduinoBot

@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2024

Hello! I'm checking your submission again.

@github-actions github-actions bot merged commit 52a748b into arduino:main Dec 15, 2024
12 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2024

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/tom-dudman/DS1804/

github-actions bot pushed a commit that referenced this pull request Dec 15, 2024
@ArduinoBot
Add submission # 5606
63b6c30 
#5606
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

No one assigned

Labels

topic: submission Add library to the list

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tom-dudman